Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutoCreateAccountTransferTransactionExample #495

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Add AutoCreateAccountTransferTransactionExample #495

merged 3 commits into from
Sep 5, 2023

Conversation

rwalworth
Copy link
Contributor

@rwalworth rwalworth commented Aug 30, 2023 •
edited
Loading

Description:
This PR adds the AutoCreateAccountTransferTransactionExample, which shows users how to use public keys to act as Hedera accounts and how they can be used. It also adds some features to TransactionReceipt.

Related issue(s):

Fixes #494

Notes for reviewer:
This PR depends on work done in #493, so that PR should be reviewed and merged first.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth linked an issue Aug 30, 2023 that may be closed by this pull request
Add AutoCreateAccountTransferTransactionExample #494
Closed
@rwalworth rwalworth changed the title Something's weird, I don't know what I did' Add AutoCreateAccountTransferTransactionExample Aug 30, 2023
@rwalworth rwalworth requested a review from deyanzz August 30, 2023 19:41
@rwalworth rwalworth self-assigned this Aug 30, 2023
@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Aug 30, 2023
@rwalworth rwalworth marked this pull request as ready for review August 30, 2023 19:42
rwalworth and others added 2 commits September 5, 2023 14:18
@deyanzz deyanzz force-pushed the 00494-add-autocreateaccounttransfertransactionexample branch from 84f8537 to 05c6162 Compare September 5, 2023 12:04
deyanzz
deyanzz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the changes I've made in 05c6162 should be double-checked.

@rwalworth
Use optional argument for TransactionReceipt::fromProtobuf as transac…
9072fc1 
…tion ID may not be always provided

Signed-off-by: Rob Walworth <[email protected]>
@rwalworth
Copy link
Contributor Author

LGTM, but the changes I've made in 05c6162 should be double-checked.

I switched it around a bit to use optional arguments instead of a std::optional as I think this is more straightforward and doesn't require std::nullopt anywhere.

deyanzz
deyanzz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. These fixes are more correct than mine.

@rwalworth rwalworth merged commit 8ef1414 into main Sep 5, 2023
2 checks passed
@rwalworth rwalworth deleted the 00494-add-autocreateaccounttransfertransactionexample branch September 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyanzz deyanzz deyanzz approved these changes

Assignees

@rwalworth rwalworth

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AutoCreateAccountTransferTransactionExample
2 participants
@rwalworth @deyanzz